Enforce rollback safety PR checks - #5731
Merged
Merged
Conversation
This reverts commit 2c10c76.
…rgo-ci-merge-5687 # Conflicts: # tools/ci/README.md # tools/ci/src/main.rs
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Aug 19, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Aug 19, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Aug 19, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
…etimeDB into bfops/rollback-safety
bfops
force-pushed
the
bfops/rollback-safety
branch
from
August 19, 2026 21:00
283bfd0 to
c982950
Compare
jdetter
reviewed
Aug 26, 2026
jdetter
reviewed
Aug 26, 2026
jdetter
left a comment
jdetter
left a comment
Contributor
There was a problem hiding this comment.
Few more Qs on this. I don't have anything blocking so after you respond I'm pretty much fine to approve 👍
jdetter
approved these changes
Sep 1, 2026
jdetter
left a comment
jdetter
left a comment
Contributor
There was a problem hiding this comment.
This looks great now, thanks for the updates 👍
bfops
enabled auto-merge
September 1, 2026 16:55
bfops
disabled auto-merge
September 1, 2026 16:59
gefjon
approved these changes
Sep 1, 2026
gefjon
left a comment
gefjon
left a comment
Contributor
There was a problem hiding this comment.
The new PR template looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates the PR template with a new section for noting PRs that must be released before the current PR can merge. We also add a CI check that this field has been updated, and to enforce that those PRs have actually been released.
A lot of the logic is added in a separate library so that it could hypothetically be used either from release flows or CI flows, without introducing a direct dependency between the two of them (it's not obvious to me that CI "should" depend on release, or vice-versa).
API and ABI breaking changes
None
Expected complexity level and risk
2
Rollback safety impact
n/a
Testing